Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to use parameters and properties in the variable action and condition #7124

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

Allow to use parameters and properties in the variable action and condition #7124

wants to merge 24 commits into from

Conversation

D8H
Copy link
Collaborator

@D8H D8H commented Nov 3, 2024 •
edited
Loading

Changes

  • Properties and parameters can be used in the primitive variable conditions
  • Properties can be used in the primitive variable action
  • Change the priority to:
    • Global variables
    • Scene variables
    • Properties
    • Parameters
    • Local variables

Technical solution

  • Properties and parameters are used to generate the VariablesContainersList.
    • It allows to finely choose the priority.
    • It's consistent to what is already done for the ObjectsContainerList.
  • Variable instructions uses 2 new parameter types variableOrPropertyOrParameter and variableOrProperty.
    • Instructions that use variables are references still use the parameter type variable.

TODO

  • Try to find regressions

@D8H D8H force-pushed the property-as-variable branch from f676bd5 to 9a7b060 Compare November 16, 2024 21:06
@D8H D8H force-pushed the property-as-variable branch 2 times, most recently from ec408b7 to 6c098a5 Compare November 25, 2024 17:58
D8H added 23 commits December 6, 2024 15:53
@D8H
Expose parameters and properties in VariablesContainerList.
6497a28
@D8H
Add new parameter type variableOrPropertyOrParameter and variableOrPr…
d06de4f 
…operty.
@D8H
Add code generation.
9278d9c
@D8H
Fix expression validator.
a18caf0
@D8H
Fix Core tests.
ed4b799
@D8H
Fix GDevelop.js tests.
59d9bab
@D8H
Add code generation tests.
db2b190
@D8H
Add test with name collisions.
94599be
@D8H
Fix variable type detection.
94d6602
@D8H
Add a refactoring operation for property type change.
86320f8
@D8H
Add tests for property renaming.
4fa03dc
@D8H
Fix property renaming.
86c7469
@D8H
WIP: Rename parameters
03b6dc2
@D8H
Fix object parameter renaming.
26f4c2d
@D8H
Refactor object renaming to use ArbitraryEventsWorker.
d9ec7fd
@D8H
Check renamed object container.
ed6968d
@D8H
Fix tests comments.
a564adb
@D8H
Fix unintended renaming of object where it's a variable.
48087a4
@D8H
Plug the refactor in the editor.
fb298fa
@D8H
Put back a condition removed by mistake.
c0021ac
@D8H
Add tests for parameter renamed in variable parameters.
72c4d62
@D8H
Add a refactoring operation for parameter type change.
42eae7a
@D8H
Fix a regression in code generation for local variables in behavior f…
4da9783 
…unctions.
@D8H D8H force-pushed the property-as-variable branch from 6c098a5 to 4da9783 Compare December 7, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4ian 4ian Awaiting requested review from 4ian 4ian will be requested when the pull request is marked ready for review 4ian is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@D8H